Find Static Method Code Issue: Listing 1

Full code for custom code issue

Listing 1: Find Static Method Code Issue
using System;
using System.Collections.Generic;
using System.ComponentModel.Composition;
using System.Linq;
using System.Threading;
using Roslyn.Compilers;
using Roslyn.Compilers.Common;
using Roslyn.Compilers.CSharp;
using Roslyn.Services;
using Roslyn.Services.Editor;

namespace VSMRolynCTP.DemoCodeIssue
{
    [ExportSyntaxNodeCodeIssueProvider("VSMRolynCTP.DemoCodeIssue", LanguageNames.CSharp,
        typeof(MethodDeclarationSyntax))]
    class CodeIssueProvider : ICodeIssueProvider
    {
        private readonly ICodeActionEditFactory editFactory;

        [ImportingConstructor]
        public CodeIssueProvider(ICodeActionEditFactory editFactory)
        {
            this.editFactory = editFactory;
        }

        public IEnumerable GetIssues(IDocument document, CommonSyntaxNode node,
 CancellationToken cancellationToken)
        {
            var methodDeclaration = (MethodDeclarationSyntax)node;
            var semanticModel = document.GetSemanticModel(cancellationToken);

            if (methodDeclaration.DescendentTokens().Any(x => x.Kind == 
SyntaxKind.StaticKeyword))
            {
                yield return null;
            }
            else
            {
                IEnumerable memberIdentifiers = from m in
 methodDeclaration.DescendentNodes()
                                                                where m as IdentifierNameSyntax
 != null
                                                                &&
 IsClassMember(cancellationToken,semanticModel,m as ExpressionSyntax)
                                                                select m as IdentifierNameSyntax;

                if (!memberIdentifiers.Any())
                {
                    yield return new CodeIssue(CodeIssue.Severity.Info, methodDeclaration.Span,
                   String.Format("{0} can be made static.", methodDeclaration));
                }
            }
        }

        private static bool IsClassMember(CancellationToken cancellationToken, ISemanticModel
 semanticModel, ExpressionSyntax syntax)
        {
            bool isMember = false;

            var memberInfo = semanticModel.GetSemanticInfo(syntax, cancellationToken);
            
            if (memberInfo.Symbol != null && !memberInfo.Symbol.IsStatic && 
                memberInfo.Symbol.OriginalDefinition.Kind != CommonSymbolKind.Local)
            { 
                isMember = true;
            }

            return isMember;
        }

        #region Unimplemented ICodeIssueProvider members

        public IEnumerable GetIssues(IDocument document, CommonSyntaxToken token,
 CancellationToken cancellationToken)
        {
            throw new NotImplementedException();
        }

        public IEnumerable GetIssues(IDocument document, CommonSyntaxTrivia trivia,
 CancellationToken cancellationToken)
        {
            throw new NotImplementedException();
        }

        #endregion
    }
}

About the Author

Eric Vogel is a Senior Software Developer for Red Cedar Solutions Group in Okemos, Michigan. He is the president of the Greater Lansing User Group for .NET. Eric enjoys learning about software architecture and craftsmanship, and is always looking for ways to create more robust and testable applications. Contact him at [email protected].

comments powered by Disqus

Featured

  • Top Free Extensions for Visual Studio 2022

    With Visual Studio 2022 having debuted just one month ago, there are now dozens of new extensions available specifically targeting the revolutionary 64-bit IDE.

  • Green Motherboard Closeup Graphic

    How to Compute Transformer Architecture Model Accuracy

    Dr. James McCaffrey of Microsoft Research uses the Hugging Face library to simplify the implementation of NLP systems using Transformer Architecture (TA) models.

  • VS Code Snippets Leads Recent Open Source GA Announcements

    GitHub's "Release Radar" for November shows a Visual Studio Code snippets project leading a raft of open source offerings that reached general availability in November.

  • C# Language Server Revamps VS 2022 Razor Editor for ASP.NET Core

    Microsoft is touting new capabilities in ASP.NET Core web development in Visual Studio 2022 thanks to a new Razor editor powered by a Razor Language Server.

Upcoming Events